feat: add prerelease VSIX validation step#164
Merged
Conversation
Addresses PR review high priority item #4: - Validates VSIXs are marked as prerelease when pre-release: true - Extracts package.json from VSIX and checks version has -pre suffix - Fails build if any VSIX is not properly marked - Only runs validation when pre-release input is true This ensures the --pre-release flag was properly passed to vsce.
peternhale
approved these changes
Jul 21, 2026
peternhale
left a comment
peternhale
left a comment
Contributor
There was a problem hiding this comment.
Approved. Solid, useful addition — verifies that --pre-release was actually honored by vsce before shipping. Core logic is correct: multiline output reuse of the VSIX file list is clean, the empty-guard is correct, and paths with spaces are handled.
Minor non-blocking notes for follow-up:
- PR description mentions extracting package.json / checking a
-preversion suffix, but the implementation checksextension.vsixmanifestfor the PreRelease property (which is actually the better approach). Worth updating the description. - The
grep -qshort-circuit inside a command substitution underpipefailis slightly fragile, though it won't fire in practice given manifest sizes. - Emoji log output is inconsistent with the plain-text style elsewhere in this workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PR review high priority item #4:
This ensures the --pre-release flag was properly passed to vsce package command.